Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear traps in monster tests #36865

Merged
merged 2 commits into from
Jan 10, 2020
Merged

Clear traps in monster tests #36865

merged 2 commits into from
Jan 10, 2020

Conversation

ZhilkinSerg
Copy link
Contributor

Summary

SUMMARY: None

Purpose of change

See #36664 (comment)

@ZhilkinSerg ZhilkinSerg added Code: Tests Measurement, self-control, statistics, balancing. [C++] Changes (can be) made in C++. Previously named `Code` Monsters Monsters both friendly and unfriendly. <Bugfix> This is a fix for a bug (or closes open issue) labels Jan 10, 2020
@kevingranade
Copy link
Member

Can invoke clear_traps() outside the loops since we aren't shifting the map anymore.

@kevingranade kevingranade merged commit c304911 into master Jan 10, 2020
@ZhilkinSerg ZhilkinSerg deleted the tests-monster-clear-trap branch January 10, 2020 21:01
@weekly-digest weekly-digest bot mentioned this pull request Jan 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. Monsters Monsters both friendly and unfriendly.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZhilkinSerg @kevingranade