-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add four new cookbooks #36793
Add four new cookbooks #36793
Conversation
```SUMMARY: Content "Add four new cookbooks"```
It looks like this PR doesn't actually shuffle around any existing recipes, but simply adds more sources for some that are already in place. I thought part of the plan was to make it so that it took more than a few textbooks for a character to master a skill? This may not be a problem, but it is something I'm confused about. |
I didn't add any new recipes, I only used existing ones.
This PR is only to add greater variety to the world (ie clutter). Now "Bon Appetit" and "Cucina Italiana" won't be the only cookbooks you regularly come across. |
The names of these are weird. Think what you would actually call it if you were publishing. |
@ymber supposed to be funny, but actually most of them are based off real books! See https://www.pinterest.com/jerimee/books/cookbooks/ |
If they're real go for it. I think 60%-70% overrepresents those kind of old books in the itemgroup though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's still missing some stuff... there don't seem to be any recipes in Eatyrway for example.
Don't be afraid to remove a few recipes from overloaded books if they fit better here.
Co-Authored-By: matskuman5 <selinmatias5@gmail.com>
Co-Authored-By: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Co-Authored-By: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Co-Authored-By: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Co-Authored-By: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Co-Authored-By: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Yeah, eatyrway doesn't have any recipes, just skill training. Maybe I could add
|
I'd go with protein shake and things like that |
Co-Authored-By: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Yeah, that's what I planned to do, but most of the recipes are autolearn: true (including protein shake) |
I would suggest putting Tofu on the list for the boring book, at least. More could be considered later. I think someone needs to do an audit of what's on autolearn, honestly, and remove some stuff like hard cheese and several other very non-intuitive recipes. |
Co-Authored-By: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
TODO: put tofu (line 541), tofu_fried (555) and pizza_veggy (3505) on the eatyrway (boring) book. I'll do this tonight. |
Summary
SUMMARY: Content "Add four new cookbooks"
Purpose of change
This adds 4 new cookbooks to cooking.json, and adds them to some loot tables.
Describe the solution
Book entries added to data/json/items/book/cooking.json
loot tables modified at:
4.. added SUS_cooking_bookcase to kitchen_counters in itemgroups/collections_domestic.json - this means an entire counter might be dedicated to cookbooks (which is a real enough occurrence)
Recipes added to books at:
Describe alternatives you've considered
The plurals I've used do not have the extended name of the book, as there are easily identified shorter names. So, for example, one book is called "Dainty Dishes Fit for a King," and the plural is "copies of Dainty Dishes." Alternatively, this could be "copies of Dainty Dishes Fit for a King." I prefer the shorter version for the sake of the UI.
I considered having these cookbooks not contain recipes for the sake of simplicity, and I considered that it might be desirable for cookbooks to have a larger number of recipes.
Testing
Testing done locally via wishing for the items and reading the books in game.
Referenced the doc at JSON_INFO.md#books, JSON_INFO.md#recipes, JSON_INHERITANCE.md, ITEM_SPAWN.md
Additional context
These books do not solve any problem nor are the part of any larger design. They are merely additional clutter content for variety. Note that some of the books contain recipes, but the recipes themselves are not new.
The books are:
For each of the recipes associated with the books I added a third display entry to reflect the theme of the particular cookbook. These display entries did not seem to work. See #36790