Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magiclysm: Forest Tomb #36672

Closed
wants to merge 25 commits into from
Closed

Magiclysm: Forest Tomb #36672

wants to merge 25 commits into from

Conversation

arijust
Copy link
Contributor

@arijust arijust commented Jan 3, 2020

Summary

SUMMARY: Mods "Magiclysm: Forest Tomb"

Purpose of change

Add new low-tier dungeon to Magiclysm.

Describe the solution

Add forest tomb, small tomb in forest with few enemies, but decent chance to get animist books and low-tier magic tools,

Describe alternatives you've considered

Stay content with doing monsters and furniture only, if this location is poor quality too.

Additional context

I made pull request earlier to see reaction for that one.
I also need to add some monsters and add loot before actually releasing this.

@mkikt4743
Copy link

seems cool and good

data/mods/Magiclysm/worldgen/forest_tomb.json Show resolved Hide resolved
" ################## ",
" ################## ",
" S ####..##>>##...### ",
" ###$..........####S ",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also can't find x and $ in definitions. Are they monsters?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ is weaker monsters.
x is loot.
I will probably reverse these two.

" S ",
" T T ",
" S ",
" S "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like Travis feels you need one more row of terrain? I'm not sure why but that's what the test looked like to me.

@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Mods: Magiclysm Anything to do with the Magiclysm mod Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods Issues related to mods or modding labels Jan 4, 2020
@arijust arijust marked this pull request as ready for review January 5, 2020 17:41
@arijust arijust changed the title [WIP] Magiclysm: Forest Tomb Magiclysm: Forest Tomb Jan 6, 2020
@KorGgenT KorGgenT requested a review from curstwist January 18, 2020 01:29
Copy link
Contributor

@curstwist curstwist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loot and risk seem reasonable.

Requested change:
I'd suggest adding some upslopes to the outside of the ruin, like the LMOE shelter has, to make it a mound. If it's a man made tomb, use the smooth stone walls instead fo natural rock.

Optional:
For the underground area, if this is a tomb, adding some caskets or making a new sarcophagus furniture could help make it different from a natural cavern. If you want to keep it natural, there are also some new underground terrains you can add.

Adding some atmospheric items spawns like candles, mementos or forest litter will fill it out some. Even the corpse and heavily degraded clothing of past adventurers : ).

data/mods/Magiclysm/worldgen/forest_tomb.json Outdated Show resolved Hide resolved
@arijust
Copy link
Contributor Author

arijust commented Jan 21, 2020

Closing this for certain amount of time.
I need to redo this location at new git branch.

@arijust arijust closed this Jan 21, 2020
@KorGgenT
Copy link
Member

it seemed like it was coming together, so i hope to see it soon

@arijust arijust deleted the magiclysm_tomb branch February 4, 2020 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants