Book editing #36631
Merged
Book editing #36631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qrox
reviewed
Jan 2, 2020
data/json/items/book/maps.json
Outdated
| "s_hunting", | ||
| "mil_surplus", | ||
| "s_gas" | ||
| ], |
There was a problem hiding this comment.
The convention is to put an array or an object in a single line if it's short enough. The JSON formatter will complain if you wrap it this way.
There was a problem hiding this comment.
i see. i'll change that one back. how short is short enough?
There was a problem hiding this comment.
I think it's 120 characters, but you can just use the json linting tool. Copy a changed file into it, hit "lint", and copy the output back.
There was a problem hiding this comment.
Paste the json in the web linter and it will format it for you. http://dev.narc.ro/cataclysm/format.html
|
yay it worked this time |
This was referenced Jan 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: NonePurpose of change
I've read through all the files in json/items/book, editing as I go. Fixed a few mistakes. Mostly I've expanded the definitions of variants in misc.json onto multiple lines.
Describe alternatives you've considered
I put double dashes on this line because a similar book had double dashes. I could have changed the other one to single dashes, this seemed better?
I changed this from "this recent edition includes extensive data on what was the latest techniques", I'm not absolutely sure about this one.
Testing
I've copied the edited files over to one of my game installations and checked a few of the books in the debug spawner.