Fix building with ccache. #36583
Merged
Fix building with ccache. #36583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building with ccache enabled, it removes the comments before passing them to the compiler. So the `/* fallthrough */` comment that prevents certain warnings is removed as well. Adding the `-C` switch prevents that removal and the comments remains and the warning from the compiler does not appear.
|
Ahhhh!!!! finally! I was trying to figure this out well over a year ago and was never able to. |
This instructs ccache directly. The former version relied on gcc to interpret the "-C" flag, but clang apparently does not understand it.
|
I changed it: the "-C" flag was specific to gcc, and clang apparently did not get it. New version instructs ccache directly. But be aware: this only works since ccache v3.5.1. |
ZhilkinSerg
added
the
Code: Build
This was referenced Jan 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY: Build "Fix building with ccache"When building with ccache enabled (
make CCACHE=1), I get the following error (from several files, and several switch statements):Turns out,
ccacheremoves the comments before passing them to the compiler. So the/* fallthrough */comment that prevents that error normally gets removed as well.Adding the
-Cswitch prevents that.