Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all CROWS type turrets with computer action #36462

Merged
merged 1 commit into from
Dec 26, 2019

Conversation

ymber
Copy link
Member

@ymber ymber commented Dec 26, 2019

Summary

SUMMARY: Bugfixes "Despawn correct turrets when using card reader"

Purpose of change

Fixes #36415

Describe the solution

Add all M153 CROWS II type turrets to despawn check.

Describe alternatives you've considered

Despawning based on some flag. TURRET is only applicable to vehicle parts and no other usable flag exists for this right now so I went with the easy solution. Really this whole despawning system needs reworking and JSONizing.

Testing

Turrets despawn as expected.

@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Monsters Monsters both friendly and unfriendly. labels Dec 26, 2019
@ZhilkinSerg ZhilkinSerg merged commit cfa0c4c into CleverRaven:master Dec 26, 2019
@ymber ymber deleted the turret_despawn branch December 26, 2019 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Monsters Monsters both friendly and unfriendly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Card readers only despawn M249 turrets but labs can spawn with antimaterial turrets
2 participants