Cap windchill heat from vapor pressure to 50C #36450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swwu
changed the title
swwu
force-pushed
the
swwu/fix-36449
branch
3 times, most recently
from
892e08a to
7dac115
Compare
The model we use to approximate windchill seems to have degenerate behavior at high "dry-bulb" temperatures; this manifests most obviously by generating apparent temperatures in the millions of celsius for input temperatures of ~1000C. Since most of this runaway extra temperature is from the vapor pressure term, and since it seems unreasonable that a given 1000C fire would actually have vapor pressure of 10MPa in its vicinity, we cap that vapor pressure-induced extra temperature to only 100C.
swwu
changed the title
curstwist
added
[C++]
|
Thanks a ton for finally getting to the bottom of this issue. |
va5h
added a commit
to va5h/Cataclysm-DDA
that referenced
this pull request
Jan 16, 2020
Retrofitted windchill fix (CleverRaven#36450)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: NonePurpose of change
Make heat transfer from fires more reasonable, instead of allowing fires to heat the player to 100000C.
Fixes #36449, #32861
Describe the solution
The model we currently use to approximate windchill seems to have degenerate behavior at high "dry-bulb" temperatures; this manifests most obviously by generating apparent temperatures in the millions of celsius for input temperatures of ~1000C.
Since most of this runaway extra temperature is from the vapor pressure term, and since it seems unreasonable that a given 1000C fire would actually have water vapor pressure of 10MPa (about 100 atmospheres) in its vicinity, we cap that vapor pressure-induced extra temperature to only 50C. This makes #36449 less of a problem, while not changing behavior in most normal gameplay situations.
Testing
Ran
./tests/cata_testlocally. Some crafting tests failed, but they appear also to be failing on currentHEADof master.Additional context