Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not set head_scaling and torso_scaling to NaN or Inf #36443

Merged
merged 1 commit into from
Dec 26, 2019

Conversation

hexagonrecursion
Copy link
Contributor

Summary

SUMMARY: Bugfixes "Fixes NaN or infinite healing scaling factor"

Purpose of change

To trigger the bug:

  1. build with clang UndefinedBehaviorSanitizer
  2. start a new game

This prints to the console:

src/iuse_actor.cpp:3412:40: runtime error: division by zero
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior src/iuse_actor.cpp:3412:40 in

Describe the solution

Describe alternatives you've considered

Testing

Additional context

@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` labels Dec 26, 2019
@ZhilkinSerg ZhilkinSerg merged commit 2581c93 into CleverRaven:master Dec 26, 2019
@hexagonrecursion hexagonrecursion deleted the patch-2 branch December 26, 2019 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants