Update deprecated headers #36417
Merged
Update deprecated headers #36417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert all C library includes to their C++ equivalents (stdio.h -> cstdio, etc.).
Enable this clang-tidy check.
ZhilkinSerg
added
[C++]
BevapDin
approved these changes
Dec 24, 2019
| if( you.wield( *orig ) ) { | ||
| orig = &you.weapon; | ||
| } else { | ||
| if( !you.wield( *orig ) ) { |
There was a problem hiding this comment.
This seems unrelated? Also I'm not sure the logic is correct.
There was a problem hiding this comment.
I see orig is never read again, so it's correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
More static analysis.
This check doesn't really matter from a code quality perspective, it's just for the sake of having a standard and being consistent about how we include C standard library headers.
Describe the solution
Enable the
clang-tidycheckmodernize-deprecated-headers.Get
clang-tidyto update all the existing old-style includes.Fix a couple of unrelated
clang-tidyerrors.Describe alternatives you've considered
We could standardize in the opposite direction, but that's not easy to check automatically.
Technically we ought to switch all our library calls to have a
std::prefix when using these headers. I think the calls that need changing can be detected using IWYU. I might do that at some point, but I don't think it needs to be in the same PR.Testing
Compiled the code.
Additional context
Inspired by a review comment on a recent PR.