Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Make fish fillets more calorie-dense (this time for real) #36413

Closed
wants to merge 2 commits into from

Conversation

cozardi
Copy link

@cozardi cozardi commented Dec 24, 2019

Summary
SUMMARY: Balance "Up the calories in fish fillet"

Purpose of change
Resolves #36302 - fish values were based on cod, a pretty lean fish, whereas now they're based on whitefish

Describe the solution
Changed fish fillet calories from 90 to 260 kcal, according to the explanation in #36302. Also changed the comment saying what the caloric values are based on.

Describe alternatives you've considered
Not changing it.

Testing
Butchered fish, their meat now has the correct caloric value, so do fish-based recipes

Additional context
Only implemented what was brought up in the issue, maybe upping the calories on fish can throw off balance, but I don't think it's that significant.

@CountAlex
Copy link
Contributor

CountAlex commented Dec 24, 2019

It seems you need resulting food items (e.g. fried fish, lutefisk, fish soup etc.) calories expectation value tweaked to meet new amount of calories provided by fish. I believe most of those are located at data\json\items\comestibles\meat_dishes.json
I suggest going through the list of those failed C/C++ build test first.

@cozardi cozardi changed the title Make fish fillets more calorie-dense (this time for real) [WIP] Make fish fillets more calorie-dense (this time for real) Dec 24, 2019
@curstwist curstwist added [JSON] Changes (can be) made in JSON Items: Food / Vitamins Comestibles and drinks labels Dec 27, 2019
@KorGgenT
Copy link
Member

cod's the most common fish in new england. what's the reasoning behind changing it to whitefish?

@Rivet-the-Zombie
Copy link
Member

Cod is a whitefish.

@cozardi cozardi closed this Dec 30, 2019
@Zourin2
Copy link

Zourin2 commented Jan 2, 2020

What happened to this PR?

Cod may be most common, but it's a very lowball calorie count compared to the other fish you can find/catch in CDDA. We'd be better off using a reasonable median value overall rather than sticking with a nutritional example that is very low. It's a bit like using the nutritional values for wild vegetables for all vegetables just because they're more common.. only we only have one kind of fish fillet and nobody's inclined to crack open the can of work to code in a dozen different fish meat types.

@KorGgenT
Copy link
Member

KorGgenT commented Jan 2, 2020

@Zourin2 the author closed it for an unspecified reason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items: Food / Vitamins Comestibles and drinks [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calorie adjustment: Fish portions
6 participants