JSONize gunmod weight multiplier #36388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove REDUCED_WEIGHT flag, add weight_multiplier json thing instead. Current result is same (25% reduced)
|
Did you test if the weight of other attached gunmods gets altered by this weight multiplier? |
It does not change the weight of other mods, i.e. it works correctly. Just tested now as we speak. |
|
Unsure what's wrong with the travis check, I've astyled everything with 3.0.1 and the options given in the instructions. |
Co-Authored-By: anothersimulacrum <anothersimulacrum@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "JSONize gunmod weight multiplier'"Purpose of change
Gunmods such as lightweight replacement furniture are hardcoded at a weight multiplier of 0.75 and this cannot be changed through JSON alone.
Describe the solution
This PR removes the REDUCED_WEIGHT flag from lightweight replacement furniture and instead adds a new JSON variable "weight_multiplier" that affects gun weight in the same way REDUCED_WEIGHT did.
REDUCED_WEIGHT has NOT been removed from the game and may still be in use elsewhere.
Describe alternatives you've considered
N/A
Testing
Take a gun and lightweight replacement furniture
Apply the furniture gunmod
See as gun weight is affected despite no REDUCED_WEIGHT flag
Additional context
This will allow even more innate-weight-affecting gunmods with different values. For a hypothetical, a steel-to-titanium gunmod that affects multiplies weight by 0.5 instead of 0.75.