minor mv bowling golf balls to toys n sports #36359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Summary ```SUMMARY: None "minor mv bowling golf balls to toys n sports"``` #### Purpose of change I cut four generic type items from items/generic.json and pasted them into items/generic/toys_and_sports.json. toy_and_sports is a specific use file; generic is not. #### Describe the solution The four items are 1) golf_tee, 2) golf_ball, 3) pool_ball, and 4) bowling_ball. They were moved into a smaller specific use file (toys_and_sports.json) along side things like baseball and football. #### Describe alternatives you've considered items/generic.json also contains some dolls and a teddy bear - I considered moving those as well #### Testing None! I'm relying syntax highlighting and the JSON validation to catch any typos. I just did a cut and paste so hopefully there isn't much that can go wrong. #### Additional context I confirmed via discord chat that it was proper to do this.
This was referenced Dec 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: NonePurpose of change
I cut four generic type items from items/generic.json and pasted them into items/generic/toys_and_sports.json.
toy_and_sports is a specific use file; generic is not.
Describe the solution
The four items are 1) golf_tee, 2) golf_ball, 3) pool_ball, and 4) bowling_ball. They were moved into a smaller specific use file (toys_and_sports.json) along side things like baseball and football.
Describe alternatives you've considered
items/generic.json also contains some dolls and a teddy bear - I considered moving those as well
Testing
None! I'm relying syntax highlighting and the JSON validation to catch any typos. I just did a cut and paste so hopefully there isn't much that can go wrong.
Additional context
I confirmed via discord chat that it was proper to do this.