Use std::string instead of std::ostringstream #36300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BevapDin
force-pushed
the
xpe
branch
3 times, most recently
from
1ceb058 to
ac5d0e8
Compare
Slightly changed some statements as to combine multiple adjacent writes of string literals into a single string literal. Also used `colorize` to get a `std::string`, to which other string literals can be added.
Mostly just make new variables within the blocks. This avoids the need to clear the variable each time. And sometimes just use the string directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY: NoneSlightly changed some statements as to combine multiple adjacent writes of string literals into a single string literal.
Also used
colorizeto get astd::string, to which other string literals can be added.