Fix phantom bread recipes from Aftershock dough obsoletion #36275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengjixuchui
added a commit
to fengjixuchui/Cataclysm-DDA
that referenced
this pull request
Dec 20, 2019
Remove phantom bread recipes (CleverRaven#36275)
ghost
deleted the
ghost
mentioned this pull request
ghost
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Remove Aftershock phantom bread recipes"Purpose of change
Obsoletion of the dough recipes in #36209 was done without adding the recipe suffix, and putting
"obsolete": "true"instead of"obsolete": true. This lead to the vanilla recipes being overwritten to require no ingredients but create the bread anyway if Aftershock was enabled.Describe the solution
Re-add suffix, fix obsolete field.
Describe alternatives you've considered
None.
Testing
Loaded ingame, saw that only the vanilla recipe was there and doesn't violate the law of conservation of mass.
Tried also without re-adding the suffix just for kicks, which obsoletes the vanilla recipe.
Additional context
Original bug(reported on Fancord by blackburn):
