Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new debug menu item for checking map extra spawns #36244

Merged

Conversation

ralreegorganon
Copy link
Contributor

Summary

SUMMARY: None

Purpose of change

While discussing #36229 it was useful to have a way to easily get the data regarding how many of a given map extra will spawn in the game.

Describe the solution

Add a new debug menu item which allows the user to pick from the lists of map extra collections defined in the region settings, and then runs the selection using their chance and weighted lists and records which extras are selected, and finally reports that.

Testing

Loaded the game, ran the debug menu item for all of the map extra lists.

Additional context

I had it run 32,400 times because that's one z-level for an overmap (180x180) and it's a big enough sample size to get the rare map extras on the list, even if it's only once. Having a much smaller sample size would be more representative of "what extras might I see within my field of view", but I think it's probably easier to have the larger set and manipulate it if you want something like the smaller sample size.

image

image

@ralreegorganon ralreegorganon added [C++] Changes (can be) made in C++. Previously named `Code` Map / Mapgen Overmap, Mapgen, Map extras, Map display labels Dec 19, 2019
@ZhilkinSerg ZhilkinSerg merged commit c6ee1cf into CleverRaven:master Dec 19, 2019
@ralreegorganon ralreegorganon deleted the map-extra-spawn-debug-list branch April 7, 2020 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants