Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set pathfinding avoid_traps to true by default #36238

Merged
merged 1 commit into from Jan 4, 2020
Merged

Set pathfinding avoid_traps to true by default #36238

merged 1 commit into from Jan 4, 2020

Conversation

ghost
Copy link

@ghost ghost commented Dec 18, 2019

Summary

SUMMARY: Bugfixes "Set pathfinding avoid_traps to true by default"

Purpose of change

Fixes #36079

Describe the solution

Character does not avoid traps by default in pathfinding settings,
so ive flipped that to true, and now they do.

Describe alternatives you've considered

I have no idea why it was set to false to not avoid traps, by default, maybe theres a very good reason for this, maybe someone will tell me why its that way. But it fixes the issue, and It seems to make sense that pathfinding should avoid traps?

Testing

Tested on evac shelter roof, deconstructing the railings, before this fix, it kept sotpping with a message about stepping over the ledge, after the fix it pathed to spots it could walk to to do the deconstruction as it considered open air not a valid destination.

Additional context

N/A

@I-am-Erk I-am-Erk added [C++] Changes (can be) made in C++. Previously named `Code` Mechanics: Character / Player Character / Player mechanics labels Dec 19, 2019
@jbytheway
Copy link
Contributor

Does this cause pathfinding to magically avoid traps the player shouldn't yet know about? That might have been a reason to not have this behaviour before.

@ghost
Copy link
Author

ghost commented Jan 1, 2020

Does this cause pathfinding to magically avoid traps the player shouldn't yet know about? That might have been a reason to not have this behaviour before.

Ah hah, perhaps.

Ill test that when I have a moment.

@ghost
Copy link
Author

ghost commented Jan 3, 2020

Just tested, and the player does not avoid traps that are not seen, with this change.
( i.e they will still walk into a buried bear trap if they dont spot it )

I cant think of any further reason why this isnt a suitable fix.

@ghost ghost changed the title [CR]Set pathfinding avoid_traps to true by default Set pathfinding avoid_traps to true by default Jan 3, 2020
@kevingranade kevingranade merged commit ed9e547 into CleverRaven:master Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Mechanics: Character / Player Character / Player mechanics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not avoiding open air while performing zone activities
3 participants