Standardize player info window colors #36178
Conversation
|
Could you show pictures? |
|
Hmm. I can do a before/after of the encumbrance tab and a before/after of the effects tab, which are probably the most-interesting -- the others are really just changing to use light gray for the text in the description area.
|
|
Each of these originally just used magenta in the description area; now the description is light gray, with the stats numbers highlighted in white. |
|
Maybe make each value start on a new line, like the values in STATS tab? |
|
In the encumbrance tab? Sure, looks like there's room for all the current (non-localized) text to put each stat on a line for each body part if you want...but note that that the field is pretty tight on space, and it might be preferable to leave space to describe any future mechanics that are affected. That'd take the hands description down to only one blank line remaining. |
|
Eh, I'll just go ahead and do it. Someone can go change the field up if they need more space. |
Previously, the colors and format used on the player info window had varied from tab to tab. Make all tabs conform to the color convention used in the STATS tab: Magenta is reserved for text that must be set off from the rest, white for numeric stats to make them stand out, light gray for everything else. Convert "sentence"-based structure of ENCUMBRANCE AND WARMTH tab to one-line-per-stat format.
mark7
force-pushed
the
wb-playerstatus-color
branch
from
559e4cf to
a034395
Compare
|
|
|
Yeah, that's what I meant. |
I-am-Erk
added
[C++]
|
The continuous integration failure doesn't look related to the patch to me. |
Merge pull request CleverRaven#36178 from mark7/wb-playerstatus-color
Summary
SUMMARY: Interface "Standardize player info colors"
Purpose of change
Previously, the colors used in the player info window had varied from
tab to tab. Make all tabs conform to the color convention used in the
STATS tab: Magenta is reserved for text that must be set off from the
rest, white for numeric stats to make them stand out, light gray for
everything else.
Added one missing period to "hands" encumbrance description.
Testing
Hit "@" to bring up the player info window, scrolled through each tab.