Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix display of repair possibility info for items made of certain materials #36155

Merged

Conversation

ZhilkinSerg
Copy link
Contributor

@ZhilkinSerg ZhilkinSerg commented Dec 16, 2019

Summary

SUMMARY: Interface "Fix display of repair possibility info for items made of certain materials"

Purpose of change

Fixes #36148

Describe the solution

See commit messages.

Testing

See that items made of wood, paper, bone and chitin previously showed as non-repairable are now displaying items they can be repaired with.

@ZhilkinSerg ZhilkinSerg added Info / User Interface Game - player communication, menus, etc. [C++] Changes (can be) made in C++. Previously named `Code` Items / Item Actions / Item Qualities Items and how they work and interact <Bugfix> This is a fix for a bug (or closes open issue) labels Dec 16, 2019
@kevingranade
Copy link
Member

We would like to get rid of this special case together with MISC_REPAIR iuse action eventually

I don't see a pressing need to keep it, just nuke the resinous cord.

@ZhilkinSerg ZhilkinSerg force-pushed the fix-repaired-with-display branch from d37bb47 to 1c51067 Compare December 16, 2019 19:39
@ZhilkinSerg
Copy link
Contributor Author

I don't see a pressing need to keep it, just nuke the resinous cord.

Done.

@ZhilkinSerg ZhilkinSerg force-pushed the fix-repaired-with-display branch from 06f516d to b78688f Compare December 16, 2019 20:24
@kevingranade kevingranade merged commit b918ea5 into CleverRaven:master Dec 18, 2019
@ZhilkinSerg ZhilkinSerg deleted the fix-repaired-with-display branch December 18, 2019 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. Items / Item Actions / Item Qualities Items and how they work and interact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spears incorrectly display as unrepairable in vanilla.
2 participants