Add item::get_food #36119
Merged
Add item::get_food #36119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BevapDin
reviewed
Dec 15, 2019
There were many places in the codebase which had to fetch either an item or its contents, depending on which was food. Factor that logic out into a new item member function, to simplify code elsewhere.
jbytheway
force-pushed
the
item_get_food
branch
from
97fca87 to
5dcafd0
Compare
ZhilkinSerg
added
[C++]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
There were many places in the codebase which had to fetch either an item or its contents, depending on which was food. This led to code duplication and distraction from the main intent of the code.
Describe the solution
Factor that logic out into a new item member function, to simplify code elsewhere.
Testing
Unit tests.
Additional context
A side-project during my work on #28180, where I also found myself needing this functionality.