updates to doc\MONSTERS.md #36116
Merged
updates to doc\MONSTERS.md #36116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I-am-Erk
requested changes
Dec 15, 2019
KorGgenT
added
the
<Documentation>
Jerimee
commented
Dec 18, 2019
|
@I-am-Erk sorry for hassle - I did a bunch of weird stuff to try and clean up github fork and this PR suffers from that. This PR should be merged or closed without merging. Let me know if you'd like me to close it myself. |
|
I don't think you need to do final edits in a second PR. Just add the phrases describing what units are accepted to your current changes. It's well within the scope of this PR |
|
I think I made the changes requested (re units accepted). I've made multiple forks (using organizations) and then archived them (including the one associated with this PR) as I flail about making a giant mess of my local repo. I was trying to spare myself the trouble of unarchiving etc etc etc. But I think I did it correctly. |
I-am-Erk
approved these changes
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: NonePurpose of change
Minor updates to the documentation for name, volume, and weight of monster JSONDescribe alternatives you've considered
These changes are based upon instructions I received from active/trusted contributors. I double checked and asked follow up questions in an attempt to be as accurate as possible.Additional context
only one file should be changed: MONSTERS.md