Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ellipsis pref to style manual #36109

Merged
merged 1 commit into from
Dec 16, 2019

Conversation

Jerimee
Copy link
Contributor

@Jerimee Jerimee commented Dec 14, 2019

Summary

Summary: None

@I-am-Erk
Copy link
Member

As discussed elsewhere, I pretty strongly disagree with this being a preference, since it's not readily accessible from most JSON editing tools like notepad++.

@Jerimee Jerimee closed this Dec 14, 2019
@Jerimee Jerimee deleted the patch-8 branch December 14, 2019 21:02
@Jerimee Jerimee restored the patch-8 branch December 14, 2019 21:04
@Jerimee Jerimee reopened this Dec 14, 2019
@Jerimee
Copy link
Contributor Author

Jerimee commented Dec 14, 2019

@I-am-Erk I remember you saying that. Me personally, I don't care what the standard is, so long as it is consistent. I think currently the JSON validation script will fail if you have "..."

I don't know if this counts as "readily accessible" (I suppose it doesn't) but as you likely know the character insertion tool in Notepad++ is edit - > Character Panel (and then ascii 133).

@I-am-Erk
Copy link
Member

The JSON validation probably won't fall on "..." since using periods in mapgen is extremely common.

I know it's possible to add ”…" as a special character, but that's a pretty big pain in the butt when trying to type dialogue, for no real benefit.

@Qrox
Copy link
Contributor

Qrox commented Dec 15, 2019

The JSON validation probably won't fall on "..." since using periods in mapgen is extremely common.

Actually the unit test currently fails on "..." in a subset of the translatable JSON strings. And in my personal opinion it's not that much of a hassle: you can always type the dialogue using three dots, and change them to the ellipsis in a final commit.

@KorGgenT KorGgenT added the <Documentation> Design documents, internal info, guides and help. label Dec 15, 2019
@Davi-DeGanne
Copy link
Contributor

Hmm, what if I (or somebody else, if they want) added a ... to to the linter? Would that help? @I-am-Erk

@I-am-Erk
Copy link
Member

You'd have to make it distinguish between any time "..." appears in mapgen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Documentation> Design documents, internal info, guides and help.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants