Fix items not appearing on regional terrains #36008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I-am-Erk
added
[JSON]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix items not appearing on regional terrain"Purpose of change
Items were not appearing in fields and forests, and indeed anywhere with a regional pseudoterrain: these terrains all had a noitem flag, which was being processed before the correct regional terrain was layered on top.
Fixes #36006
Describe the solution
Remove the noitem flag. Leave it in place for region trees though, because they shouldn't have items.
Describe alternatives you've considered
Giving the middle finger to people who look for rocks in fields.
Testing
Removed flag, items spawn correctly. Yay.