Allow plant mutants to sleep in planter furniture

[AlexanderBodnya]

Summary

SUMMARY: Features "Allow plant mutants to sleep in planter furniture"

Purpose of change

Currently plant mutants can't sleep anywhere except outside, which could be a little punishing during winter. Also it seems logical to be able to craft something like "soil bed", planter furniture seems ideal for this purpose.

Describe the solution

1. I've added new conditions when checking for plantsleep locations, to make sure that plant mutant can sleep on diggable soil AND f_planter and not on any other furniture and terrain.

2. I've added PLOWABLE flag to the f_planter furniture in order to make ROOTS2/3 mutation trigger when standing on planter furniture.

Describe alternatives you've considered

Don't do it.

Testing

1. I've run unit tests, all checks passed.
2. I've loaded game, gave myself plant treshold mutation, and Rooter with Chlorophor mutations. I've spawned planter on rock surface and tried to sleep in it - worked well. Tried to sleep on rock surface - was unable to, as expected. Tried to sleep on a diggable ground - works as expected, same goes for Rooter when I've tried to wait while standing on diggable soil(works), rock floor(does not work), planter(works).
3. Sleeping inside buildings on the planter does not give any benefits, as it required to be outside to receive nutrition.

Additional context

It feels like sleeping in planter should give some benefits, not all of them, but some. Maybe thirst reduction, but no nutrition value? I can make this change if anyone thinks it would be viable.

Feel free to correct my grammar and ask for clarifications, as I understand that my language skills are far from perfect.

[Davi-DeGanne]

Feel free to correct my grammar and ask for clarifications, as I understand that my language skills are far from perfect.

Well, you asked for it... 😈

make sure that plant mutant can sleep
make sure that plant mutants can sleep

I've spawned planter on rock surface
I've spawned a planter on a rock surface

Tried to sleep on rock surface
Tried to sleep on a rock surface

as it required to be outside to receive nutrition.
as it is required to be outside to receive nutrition.

It feels like sleeping in planter should give some benefits, not all of them, but some.
It feels like sleeping in a planter should only give partial benefits.

Anyway, these are quibbles, you illustrated all your points well; I wasn't confused by your meaning while reading.

Also -- great work, this sounds like a good change!

[AlexanderBodnya]

Feel free to correct my grammar and ask for clarifications, as I understand that my language skills are far from perfect.

Well, you asked for it... 😈

make sure that plant mutant can sleep
make sure that plant mutants can sleep
I've spawned planter on rock surface
I've spawned a planter on a rock surface
Tried to sleep on rock surface
Tried to sleep on a rock surface
as it required to be outside to receive nutrition.
as it is required to be outside to receive nutrition.
It feels like sleeping in planter should give some benefits, not all of them, but some.
It feels like sleeping in a planter should only give partial benefits.

Anyway, these are quibbles, you illustrated all your points well; I wasn't confused by your meaning while reading.

Also -- great work, this sounds like a good change!

Thanks for the corrections, my article game is worse than I imagined! =)

[Fris0uman]

Could you make a flag like ALLOW_ROOT for exemple to add to furniture instead of making a special case for f_planter?

[AlexanderBodnya]

Could you make a flag like ALLOW_ROOT for exemple to add to furniture instead of making a special case for f_planter?

Sure, did as per your request.

[AlexanderBodnya]

As a side note, CI builds whole project every time from scratch. Seems like a waste, maybe there is some way to improve it? Like having pre-built artifact of the latest master and uploading it on CI machine before building? I'm not familiar with github CI/CD, to confirm it is possible though..

[anothersimulacrum]

Please document the flags you added.

[AlexanderBodnya]

Please document the flags you added.

I added it to mapdata.h description. Is this sufficient?

[anothersimulacrum]

No, they need to be documented in doc/JSON_FLAGS.md.

[AlexanderBodnya]

No, they need to be documented in doc/JSON_FLAGS.md.

Done

[thethunderhawk]

I’m the long term it’d be super cool to let Plant Mutant players set themselves up with fertilized plant beds and indoor grow lights. Hopefully when someone gets around to working on indoor farming that’ll be more feasible.

[AlexanderBodnya]

I’m the long term it’d be super cool to let Plant Mutant players set themselves up with fertilized plant beds and indoor grow lights. Hopefully when someone gets around to working on indoor farming that’ll be more feasible.

I'll look into it, but no promises - I've only recently started to look into actual source code of the game and C++ is a new language for me. I saw a hydroponics mod, and as I know there is some kind of interface to load charges of coal into forge, so I might try to combine the two and make hydroponics furniture which require fertilizer and/or water charges, but provide some benefits of sleeping on actual soil + daylight lamp to supplement for sunlight (maybe I could reuse flashlight code, with adjusted power consumption?).

I just really enjoy playing plant, am I strange? 😂

[AlexanderBodnya]

I've resolved merging conflict, should be all good now.

[ZhilkinSerg]

Feel free to reopen if you want working on it again.

[worm-girl]

This is a cool idea, was this PR ready to go or did it need more work?

[Zireael07]

Definitely needed more work because it wasn't passing even the basic "does it build" check.