Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new zombie: Zapper zombie #35951

Merged
merged 9 commits into from
Dec 15, 2019
Merged

Implement new zombie: Zapper zombie #35951

merged 9 commits into from
Dec 15, 2019

Conversation

arijust
Copy link
Contributor

@arijust arijust commented Dec 8, 2019

Summary

SUMMARY: Content "Implement new zombie: Zapper zombie"

Purpose of change

Close #35933

Describe the solution

Zapper zombie is my suggestion for early game electric zombie.
It doesn't have ranged electric attack, but still can use zapback on melee hit.
Overall, it's slightly more durable than normal zombie.

Describe alternatives you've considered

Lower spawn rates for shocker_zombie.

Additional context

While not directly related to PR, I wanted to mention two things.

  1. monsters.json seems to be bloated and some monsters can be easily moved into other files.
  2. What about Ice/Cold-themed zombies? I am aware it would certain amount of work on C++ part.

@KorGgenT KorGgenT added Monsters Monsters both friendly and unfriendly. [JSON] Changes (can be) made in JSON labels Dec 8, 2019
@Amoebka
Copy link
Contributor

Amoebka commented Dec 8, 2019

Neither name nor description make it clear enough that "static" refers to electricity rather than lack of movement. For a zombie that's intended to be an ealy game player killer that's very dickish.

@FuelType-Memes
Copy link
Contributor

Neither name nor description make it clear enough that "static" refers to electricity rather than lack of movement. For a zombie that's intended to be an ealy game player killer that's very dickish.

Maybe "Zapper zombie" for them additional alliteration points?

@Fris0uman
Copy link
Contributor

I'd say yes to zapper zombie, also shouldn't it be the worst case of static hair [...]

Moved it closer to zombie_electric
@arijust arijust changed the title Implement new zombie: Static zombie Implement new zombie: Zapper zombie Dec 8, 2019
@Zireael07
Copy link
Contributor

+1 to name change, I was very confused when scrolling through the PR list and wondering why in the hell someone would go to the trouble of adding an umoving zombie type xDDD

Co-Authored-By: matskuman5 <selinmatias5@gmail.com>
@kevingranade
Copy link
Member

Oh we will be adding unmoving zombies later, once they can lie down in underbrush and remain mostly unseen.

Definitely no need to add CBM drops to these, we are planning on reversing that bit of life with shocker zombies anyway.

@Night-Pryanik
Copy link
Contributor

If there are no CBMs in this new monster, then we need to justify its ability to generate electricity.

@kevingranade
Copy link
Member

It's a magic space zombie.

@arijust
Copy link
Contributor Author

arijust commented Dec 9, 2019

I would rather say its ability is similar to electric eel.

@SirPendrak
Copy link
Contributor

I would say its better to either all zombies from shocker line have CBMs, or none of them having bionics.
Situation where most of them have CBMs but the most basic one doesnt is strange at least and can lead to strange situations like players intentionally leaving zappers allive so they can evolve and drop that sweet loot. Also for fluff consistency, eihter all of them have their powers from CBMs, or all of them use some kind of bio-chem-magic.

@arijust
Copy link
Contributor Author

arijust commented Dec 9, 2019

Ok.
I will get it done with all zombies on Zapper evo line, then.

@anothersimulacrum
Copy link
Member

Might be better to leave yours with no CBM harvest and the rest unchanged, then address that in a separate PR.
Because that change will require some discussion also probably adding CBMS to spawn in normal zombies with a low chance.

@SirPendrak
Copy link
Contributor

For now IMHO best option would be to give all of them the same bionics. I am not trying to oppose Kevin and his words about removing bionics from shocker line, but that should be a separate PR with a wider rebalance/rework. For now removing CBMs from all of them or leaving most basic one without CBM would be half-assed state.
That said, its strange that currently shocker brute and incadescent husk have different CBM drops than normal shocker, should be the same group for now.

@kevingranade
Copy link
Member

Removing the CBMs is fine, adding CBM drops to this new monster is not, leaving the overall CBM situation unchanged is also fine.

@FuelType-Memes
Copy link
Contributor

It's a magic space zombie.

Damn! I always thought shocker's powers came from faulty bionics, boomer's from too many beans, spitter's from too much hot ramen and scientist's from the MIT degree

@arijust
Copy link
Contributor Author

arijust commented Dec 9, 2019

leaving the overall CBM situation unchanged is also fine.

It was left unchanged. Zapper zombie has standard zombie harvest.

Co-Authored-By: Kevin Granade <kevin.granade@gmail.com>
@kevingranade kevingranade merged commit 22faa61 into CleverRaven:master Dec 15, 2019
@SirPendrak
Copy link
Contributor

If all electric zombies are space zombies, then following that logic, shouldn't they be disallowed to spawn at day one at all? Because then even theese weaker Zappers are already "unnatural", evolved zombie.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Monsters Monsters both friendly and unfriendly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace early spawning shockers with new electric zombie