Split 40mm grenade types

[ymber]

Summary

SUMMARY: Content "Rework 40mm grenades to reflect the types used by American forces"

Purpose of change

The game was treating 40x46mm grenades and 40x53mm grenades as the same thing and ignoring what components are actually required to make them. Some of the 40mm loads the game had don't actually exist. These problems led to some types of grenades being unrealistically easy to get.

Describe the solution

Split high and low velocity 40mm types. Remove fictional 40x46mm loads. Remove crafting recipes for 40mm grenades until we have M42 primers and much more manufacturing infrastructure.

Testing

Game loads and plays without errors.

[Rail-Runner]

According to this article, 40x46mm smoke and flare loads really exist (though there are multiple types); probably don't need to make them obsolete.

https://en.wikipedia.org/wiki/United_States_40_mm_grenades

[ymber]

Updated casings. For future reference the Americans pretty thoroughly documented their large caliber munitions in TM 43-0001-28. That document indicates that Federal #100 primers are used for several kinds of 40mm grenades so I'll look at bringing back some survivor crafted shotgun from hell type loads you could do with spent 40mm casings.

@Rail-Runner The kinds of flare cartridges they use don't really resemble cata flares and none of the smoke loads are intended for obscuration.

[tenmillimaster]

As promised here are the volumes I've gotten from images/drawings of each of the grenades.

Name	Casing	Caliber	Primer	measured length	diameter	Volume
m212 casing		40x46mm	.38 blank	43.54 mm	40.00 mm	54.72 mL
m199 casing		40x46mm	large pistol primer (2-1/2)	46.94 mm	40.00 mm	58.99 mL
m195 casing		40x46mm	small pistol primer(m42 or fed 100)	35.86 mm	40.00 mm	45.07 mL
m118 casing		40x46mm	small pistol primer(m42 or fed 100)	46.48 mm	40.00 mm	58.41 mL
m1006 sponge	m212	40x46mm	.38 blank	97.89 mm	40.00 mm	123.01 mL
m433 hedp	m118	40x46mm	small pistol primer(m42 or fed 100)	102.62 mm	40.00 mm	128.95 mL
m576 Buckshot	m199	40x46mm	large pistol primer (2-1/2)	67.18 mm	40.00 mm	84.42 mL
m651 tear gas	m195?	40x46mm	small pistol primer(m42 or fed 100)	79.34 mm	40.00 mm	99.70 mL
m169 casing		40x53mm	Large Rifle primer(fed 215)	50.97 mm	40.00 mm	64.06 mL
m1001 flechette	m169	40x53mm	Large Rifle primer(fed 215)	108.86 mm	40.00 mm	136.79 mL
m430a1 hedp	m169	40x53mm	Large Rifle primer(fed 215)	105.12 mm	40.00 mm	132.09 mL

I've also included the primer for each.

It is my opinion that survivors will only be able to reload buckshot, sponge, or slugs (saboted, of course) using any m118 cases, buckshot, slugs, or sponge using m199 cases, and flares or sponge grenades using the m195 or m212 cases.

For m169 casings, only flechette, buckshot or slugs should be allowed to be reloaded.

These shouldn't resemble the military loadings, and two separate recipes should be used- one for the m195 and m118 cases, and another for the m199 casings.

A swage and die set and thin sheet metal, like copper, brass or maybe aluminum, should be required to reload any of them (except the m212 cases), to get the hi-lo bursting disk part reloaded. Any of the buckshot slug or flechette loadings should use traditional shotgun materials for wads and overshot cards- paint, glue, wax, cardboard, paper, plastic, or similar. The powder needed should be shotgun powder.

[ymber]

Weights and volumes fixed. Appropriate reloads added for new 40mm types. This should be ready now.

[Davi-DeGanne]

Looks like the majority of the entries that inherit from this have "weight": "120 g". Why not add it here instead?

[ymber]

The factory loads all have different weights and the survivor loads should too. When we deal with projectile and propellant mass they'll get sorted out but for now I left them approximated at the same weight as M576.

[Davi-DeGanne]

Again, looks like this could benefit from "weight": "340 g".

[Davi-DeGanne]

I still think it's kinda weird to be adding this and the M195 casing seeing as they don't have any use. I don't know what the best solution is, though.

[ymber]

They'd be usable for different loads that I haven't added here. In another PR I might look at survivor crafted non-lethal and utility loads.

[Davi-DeGanne]

Looks like you use

      [ [ "sheet_metal_small", 1 ] ],
      [ [ "paper", 1 ], [ "wax", 1 ] ],
      [ [ "gunpowder_shotgun", 30 ] ]

quite a few times. Why not make a requirement entry for it, to reduce duplication?

[ymber]

It's not really a consistent requirement for 40x46mm reloads, the shotgun type ones just happen to share it.

[kevingranade]

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/nechronica-redux/19857/24

[kevingranade]

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/segmentation-fault-on-items/23401/2