Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix item duplication on pickup #35353

Merged
merged 1 commit into from Nov 7, 2019
Merged

Fix item duplication on pickup #35353

merged 1 commit into from Nov 7, 2019

Conversation

ghost
Copy link

@ghost ghost commented Nov 6, 2019

Summary

SUMMARY: Bugfixes "Fix item duplication on pickup"

Purpose of change

Fixes #34341
Fixes #34302

Describe the solution

The pickup code was wielding the wrong item.
So when it got switched around, and then charges were added erroneously also, it made two full stacks.
Just made the wield() func pick up the right item, and removed the amendment to its charges, as the charges are correctly set beforehand.

Describe alternatives you've considered

N/A

Testing

spawned 360 chunks of meat, picked up 80.
280 wre left on ground, I had 80 wielded.
Tried picking up entire stack by typing in 360
item on ground correctly deleted, now wielding 360.

Additional context

N/A

@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Items / Item Actions / Item Qualities Items and how they work and interact labels Nov 6, 2019
@ZhilkinSerg ZhilkinSerg merged commit f2fe3a4 into CleverRaven:master Nov 7, 2019
@ipcyborg
Copy link
Contributor

What about this issue #33189 and this PR to fix it #33422?
Changing back to u.wield( newit ) will possibly re-emerge this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Items / Item Actions / Item Qualities Items and how they work and interact
Projects
None yet
2 participants