Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 2 new NPCs. #35238

Merged
merged 12 commits into from
Jan 5, 2020
Merged

Added 2 new NPCs. #35238

merged 12 commits into from
Jan 5, 2020

Conversation

LovamKicsiGazsii
Copy link
Contributor

Summary

SUMMARY: Content "Adds 2 new NPCs to gods_community"

Purpose of change

the campground still has no NPCs. It doesn't feel as lived-in as I want it to be.

Describe the solution

I added 2 new NPCs, the food guard and the cook. They offer 4 missions altogether.
Also, I've increased food spawns, because it seemed a bit low.
To make stealing harder, I made oil lamps spawn inside.

Describe alternatives you've considered

Replacing oil_lamp_on with something more acquirable. After all, this is a debug item.
I think a new furniture like oil_lamp_holder could also be used.

Testing

The food spawns have increased and oil lamps spawn.
foodguard
The NPCs function properly and offer missions.
cook

@curstwist curstwist added [JSON] Changes (can be) made in JSON NPC / Factions NPCs, AI, Speech, Factions, Ownership labels Nov 1, 2019
@Brytenwalda
Copy link
Contributor

A great addition!

@curstwist
Copy link
Contributor

Some thoughts:
oil lamps: a new furniture may work, something with a large oil reserve. You can also add a mission to gather atomic lamps : ). Use update_mapgen to place them upon mission success.

Boxes: can a player hide in them and steal food? Escaping they guard's notice?

@Night-Pryanik
Copy link
Contributor

I think oil_lamp_on is a bad choice here. Players could kill the NPC and get the lamp, thus getting an eternal light source.

@LovamKicsiGazsii
Copy link
Contributor Author

Boxes: can a player hide in them and steal food? Escaping they guard's notice?

They can still see you stealing if the room is bright enough.

I think oil_lamp_on is a bad choice here. Players could kill the NPC and get the lamp, thus getting an eternal light source.

I'll make the oil lamp into a furniture then.

Co-Authored-By: Anton Burmistrov <Night_Pryanik@mail.ru>
@stale
Copy link

stale bot commented Dec 2, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Dec 2, 2019
@Maleclypse
Copy link
Member

Are these CI errors caused by something in the files or something else? ``src/json.cpp:111: Failed to visit member 'chance' in JsonObject at line 49:1446:
{ "item": "hat_boonie", "chance": 66 },

00:25:14.715 ERROR : src/json.cpp:111: Failed to visit member 'repeat' in JsonObject at line 57:1696:
{ "group": "snacks", "repeat": [ 1, 3 ] }

00:25:14.718 ERROR : src/json.cpp:111: Failed to visit member 'chance' in JsonObject at line 49:1457:
{ "item": "sunglasses", "chance": 50 },

00:25:14.718 ERROR : src/json.cpp:111: Failed to visit member 'chance' in JsonObject at line 57:1667:
{ "group": "snacks", "chance": 75, "repeat": [ 1, 2 ] },

00:25:14.718 ERROR : src/json.cpp:111: Failed to visit member 'repeat' in JsonObject at line 57:1703:
{ "group": "snacks", "chance": 75, "repeat": [ 1, 2 ] },

00:25:14.718 ERROR : src/json.cpp:111: Failed to visit member 'chance' in JsonObject at line 57:1785:
{ "group": "cannedfood", "chance": 50, "repeat": [ 1, 2 ] }

00:25:14.718 ERROR : src/json.cpp:111: Failed to visit member 'repeat' in JsonObject at line 57:1821:
{ "group": "cannedfood", "chance": 50, "repeat": [ 1, 2 ] } ``

@stale stale bot removed the stale Closed for lack of activity, but still valid. label Dec 5, 2019
@LovamKicsiGazsii
Copy link
Contributor Author

Strange. I am on the latest version and I don't get these errors.

@anothersimulacrum
Copy link
Member

I believe they should be visible in your debug.log

Copy link
Member

@I-am-Erk I-am-Erk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to get this merged before 0.E. Just a few quick changes.

The language overall is technically very good, but doesn't quite sound like natural speech. It's fine for now but we might want to go through and do some minor 'flavour' edits to make it a bit smoother sounding.

data/json/npcs/godco/cook.json Outdated Show resolved Hide resolved
data/json/npcs/godco/cook.json Outdated Show resolved Hide resolved
data/json/npcs/godco/cook.json Outdated Show resolved Hide resolved
data/json/npcs/godco/cook.json Outdated Show resolved Hide resolved
data/json/npcs/godco/cook.json Outdated Show resolved Hide resolved
data/json/npcs/godco/foodguard.json Outdated Show resolved Hide resolved
data/json/npcs/godco/foodguard.json Outdated Show resolved Hide resolved
data/json/mapgen/cground3x3.json Outdated Show resolved Hide resolved
LovamKicsiGazsii and others added 3 commits December 18, 2019 18:29
Co-Authored-By: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants