-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added 2 new NPCs. #35238
Added 2 new NPCs. #35238
Conversation
A great addition! |
Some thoughts: Boxes: can a player hide in them and steal food? Escaping they guard's notice? |
I think |
They can still see you stealing if the room is bright enough.
I'll make the oil lamp into a furniture then. |
Co-Authored-By: Anton Burmistrov <Night_Pryanik@mail.ru>
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered. |
Are these CI errors caused by something in the files or something else? ``src/json.cpp:111: Failed to visit member 'chance' in JsonObject at line 49:1446: 00:25:14.715 ERROR : src/json.cpp:111: Failed to visit member 'repeat' in JsonObject at line 57:1696: 00:25:14.718 ERROR : src/json.cpp:111: Failed to visit member 'chance' in JsonObject at line 49:1457: 00:25:14.718 ERROR : src/json.cpp:111: Failed to visit member 'chance' in JsonObject at line 57:1667: 00:25:14.718 ERROR : src/json.cpp:111: Failed to visit member 'repeat' in JsonObject at line 57:1703: 00:25:14.718 ERROR : src/json.cpp:111: Failed to visit member 'chance' in JsonObject at line 57:1785: 00:25:14.718 ERROR : src/json.cpp:111: Failed to visit member 'repeat' in JsonObject at line 57:1821: |
Strange. I am on the latest version and I don't get these errors. |
I believe they should be visible in your debug.log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd love to get this merged before 0.E. Just a few quick changes.
The language overall is technically very good, but doesn't quite sound like natural speech. It's fine for now but we might want to go through and do some minor 'flavour' edits to make it a bit smoother sounding.
Co-Authored-By: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Summary
SUMMARY: Content "Adds 2 new NPCs to gods_community"
Purpose of change
the campground still has no NPCs. It doesn't feel as lived-in as I want it to be.
Describe the solution
I added 2 new NPCs, the food guard and the cook. They offer 4 missions altogether.
Also, I've increased food spawns, because it seemed a bit low.
To make stealing harder, I made oil lamps spawn inside.
Describe alternatives you've considered
Replacing
oil_lamp_on
with something more acquirable. After all, this is a debug item.I think a new furniture like
oil_lamp_holder
could also be used.Testing
The food spawns have increased and oil lamps spawn.
![foodguard](https://user-images.githubusercontent.com/44979050/68053173-9b07bb00-fceb-11e9-8477-c71a3e0adbc8.png)
![cook](https://user-images.githubusercontent.com/44979050/68053171-9b07bb00-fceb-11e9-8a78-500be66b3dbb.png)
The NPCs function properly and offer missions.