Butter from raw milk and butter churn

[Maleclypse]

Summary

SUMMARY: Content "Butter recipe and butter churn"

Purpose of change

Currently as butter is not a craftable item there comes a time when there is no butter left in the world. With the advent of tameable cows and an abundance of raw milk I felt that this was an appropriate time to add this process that has existed for hundreds of years.

Describe the solution

Adds recipe for butter, adds recipe for butter churn, adds tool quality "CHURN", makes the churn created a piece of deployable furniture.

Describe alternatives you've considered

Giving up on creating wondrous buttery food items after a year of survival.

Testing

I used Experimental 9766 as a test bed. There were a couple of of errors that came up that were in sections that I never touched so I'm hoping that they don't have anything to do with my changes.

Additional context

I'm going to be without internet for a week starting tomorrow morning. Hopefully this won't require any changes but if it does I'll make them when I get back.

[KorGgenT]

your summary line is invalid. please check out the example in the template. additionally, you need to lint your changes.

[Maleclypse]

your summary line is invalid. please check out the example in the template. additionally, you need to lint your changes.

I've made it match this in look, but I'm still failing? SUMMARY: Content "Made Sledge Hammer a two-handed weapon"

[Qrox]

Your summary has an extra colon after Content.

[tenmillimaster]

Could you explain what's going on with the milk cream jar? I don't see it in your PR, but I do see the rising version.

I was expecting to find a recipe for butter made from cream, not directly from raw milk, and it'd produce unpasteurized milk as a byproduct.

From wikipedia:

Dairy products are often pasteurized during production to kill pathogenic bacteria and other microbes. Butter made from pasteurized fresh cream is called sweet cream butter. [...] Butter made from fresh or cultured unpasteurized cream is called raw cream butter. While butter made from pasteurized cream may keep for several months, raw cream butter has a shelf life of roughly ten days.

The butter in game is the pasteurized sweet cream butter.

[Maleclypse]

No errors when I test and the CI test doesn't have any errors that I can find related to my files. Thank you to everyone for the suggestions and advice on this.

[Maleclypse]

Could you explain what's going on with the milk cream jar? I don't see it in your PR, but I do see the rising version.

I was expecting to find a recipe for butter made from cream, not directly from raw milk, and it'd produce unpasteurized milk as a byproduct.

From wikipedia:

Dairy products are often pasteurized during production to kill pathogenic bacteria and other microbes. Butter made from pasteurized fresh cream is called sweet cream butter. [...] Butter made from fresh or cultured unpasteurized cream is called raw cream butter. While butter made from pasteurized cream may keep for several months, raw cream butter has a shelf life of roughly ten days.

The butter in game is the pasteurized sweet cream butter.

Somehow I missed the reasoning behind why you wanted a difference between the butters. I've found some references for raw cream butter and I'll see if I can find a calorie value for it, then once I've got that I can make a separate butter and change the butter type created. Then I guess I'll need to go and find every instance of butter in a recipe and make it have an alternate component of the raw butter. I'm currently thinking I'll do the component addition as a separate PR.

[Davi-DeGanne]

Looks good!

Regarding this:

Then I guess I'll need to go and find every instance of butter in a recipe and make it have an alternate component of the raw butter. I'm currently thinking I'll do the component addition as a separate PR.

There's only 5 appearances of butter in recipes, I don't think that really needs a separate PR.

Either way, I recommend creating a component list in cooking_components.json (e.g. "any_butter") and use that, it will make it easier for anyone adding butter alternatives in the future. It will also make it less likely that someone will fail to include raw butter when adding butter to a recipe.

[Maleclypse]

Looks good!

Regarding this:

Then I guess I'll need to go and find every instance of butter in a recipe and make it have an alternate component of the raw butter. I'm currently thinking I'll do the component addition as a separate PR.

There's only 5 appearances of butter in recipes, I don't think that really needs a separate PR.

Either way, I recommend creating a component list in cooking_components.json (e.g. "any_butter") and use that, it will make it easier for anyone adding butter alternatives in the future. It will also make it less likely that someone will fail to include raw butter when adding butter to a recipe.

OK, it looks like I've got all the merge conflicts fixed now, from creating the list. Thanks for the advice!

[Davi-DeGanne]

Looks great! Nice catch adding ghee to the list as well.