Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Magiclysm json errors #34525

Merged
merged 1 commit into from
Oct 7, 2019
Merged

Conversation

jbytheway
Copy link
Contributor

Summary

SUMMARY: Bugfixes "Fix assorted minor Magiclysm json errors"

Purpose of change

To fix json errors brought to light by the stricter json error checking I have locally (not yet PRed).

Describe the solution

The same as #34455, except for Magiclysm rather than the core game.

Describe alternatives you've considered

One of the things being attempted here which doesn't work is to give a melee weapon electrical damage. It looks like melee weapon damage ought to by lifted into a damage_instance, to match ranged damage and monster damage.

Additional context

I tackled this mod first because it's tested in CI.

Fix a bunch of errors in Magiclysm json brought to light by my new json
sanity checking.
@KorGgenT
Copy link
Member

KorGgenT commented Oct 7, 2019

a note about the electrical damage, it'll be possible eventually as my enchantment project progresses.

@KorGgenT KorGgenT merged commit d797a20 into CleverRaven:master Oct 7, 2019
@foulman
Copy link
Contributor

foulman commented Oct 7, 2019

Yeah, that's on me, I was a lot more novice at the time and didn't know that wouldn't work.
I'll re-add it once the enchantment is going.

@jbytheway jbytheway deleted the fix_magiclysm_json branch October 8, 2019 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants