Fix jumper cable not working without bio_cable CBM #33947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The jumper cable was not working - you could attach it to a vehicle, but past that, without the cable charger CBM, you could not do anything but detach it from that vehicle. This changes it to allow you to attach it to a vehicle without having the CBM.
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/jumper-cables-not-working/21296/2 |
ZhilkinSerg
added
<Bugfix>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix jumper cable not working for players without the cable charger CBM"
Purpose of change
It was impossible to do anything but detach a jumper cable from a vehicle once you had attached it if you did not have the cable charger CBM.
Resolves #33805
Describe the solution
Move the menu entry for attaching a cable from the block that appears when you only have a cable charger CBM to above that.
Describe alternatives you've considered
There seems to be some other odd behavior with the cable charger CBM and jumper cables, but none of it seems to impact functionality. I considered fixing it, but decided that was out of the scope of this PR.
Testing
Tested by spawning in a jumper cable and two vehicles. I was able to attach it to the first vehicle and then the second with this change applied, but without I was unable to do anything but detach it after attaching it to one vehicle.
I then debug installed the cable charger CBM and verified that I could still attach the jumper cable to both vehicles with that, which I was able to do.
Additional Context
Summary appears to have failed because I put a period after it - whoops!