Fix items spawning with bday at 0 instead of calendar::start_of_cataclysm #33714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
<Bugfix>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix items spawning with bday at 0"Purpose of change
Items in some locations would spawn with their bday at
0. This is wrong and they all should spawn with bday atcalendar::start_of_cataclysm.The wron bday leads to wrong rot when starting day is not zero.
Sequel for #33345
Describe the solution
Replace
0withcalendar::start_of_cataclysmin all the place_items() instances that had wrong time.Describe alternatives you've considered
Additional context
Rot going massively negative when bday is before
calendar::start_of_cataclysmshould probably be fixed too. But since items should never even have bday there that isn't important thing to fix. Negative rot also makes it easier to see that the bday is wrong (if things worked as they should most of these items would have rotted away).