Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contains in JSON to use volume string syntax #33485

Merged
merged 2 commits into from
Aug 24, 2019

Conversation

alkemann
Copy link
Contributor

@alkemann alkemann commented Aug 23, 2019

Summary

SUMMARY: Content "Changes contains values in JSON to use volume strings"

Purpose of change

Get rid of old deprecated stuff

Describe the solution

Apply the cddaUpdateJsonVolume.js script after updating it to also match contains

Describe alternatives you've considered

I considered writing my own script, because that would be more fun.

@alkemann alkemann added [JSON] Changes (can be) made in JSON Items / Item Actions / Item Qualities Items and how they work and interact labels Aug 23, 2019
@alkemann alkemann self-assigned this Aug 23, 2019
@alkemann alkemann changed the title An initial run of volume update script Update contains in JSON to use volume string syntax Aug 23, 2019
Change suggested by @ampersand55

Co-Authored-By: ampersand55 <9817636+ampersand55@users.noreply.github.com>
@alkemann alkemann marked this pull request as ready for review August 23, 2019 14:24
@alkemann alkemann removed their assignment Aug 23, 2019
@ZhilkinSerg ZhilkinSerg merged commit 40cbf11 into CleverRaven:master Aug 24, 2019
@alkemann alkemann deleted the volumes branch August 24, 2019 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants