-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change "storage" volume to metric units #33462
Merged
ZhilkinSerg
merged 21 commits into
CleverRaven:master
from
ampersand55:change_volume_to_metric
Aug 22, 2019
Merged
Change "storage" volume to metric units #33462
ZhilkinSerg
merged 21 commits into
CleverRaven:master
from
ampersand55:change_volume_to_metric
Aug 22, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into change_volume_to_metric
Co-Authored-By: anothersimulacrum <anothersimulacrum@gmail.com>
Co-Authored-By: anothersimulacrum <anothersimulacrum@gmail.com>
Co-Authored-By: anothersimulacrum <anothersimulacrum@gmail.com>
Co-Authored-By: anothersimulacrum <anothersimulacrum@gmail.com>
…into change_volume_to_metric
…into change_volume_to_metric
…into change_volume_to_metric
…d55/Cataclysm-DDA into change_volume_to_metric
ZhilkinSerg
added
[JSON]
Changes (can be) made in JSON
Items / Item Actions / Item Qualities
Items and how they work and interact
labels
Aug 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Items / Item Actions / Item Qualities
Items and how they work and interact
[JSON]
Changes (can be) made in JSON
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Change all instances of 'storage' in JSONs to be a metric string"
Purpose of change
Implements @ZhilkinSerg suggestion: #33367 (comment)
Describe the solution
See #33367.
Describe alternatives you've considered
Additional context