ApocPrice added #33445
ApocPrice added #33445
Conversation
Adds "price_postapoc" to all ammo types, used existing price as price_postapoc" guesstimated pre cataclysm price with current prices and inflation and sensibility. Example rounded 9mm to $1 rather than put in 18 cents. If someone wants to make use of these feel free to edit prices. This was more about building infrastructure.
|
Should I be concerned about the failed checks? I used a build from last night, and I made minimally invasive changes as a first time editor. |
Co-Authored-By: Kevin Granade <kevin.granade@gmail.com>
|
Looks like a bunch of other instances of the same issue, make sure there are spaces after colons. |
I went through every line and I believe I've caught all the missed spaces after colons. Thank you! I also caught an additional ammo type that I'd missed adding price_postapoc to. |
ZhilkinSerg
added
[JSON]
Co-Authored-By: ZhilkinSerg <ZhilkinSerg@users.noreply.github.com>
Co-Authored-By: ZhilkinSerg <ZhilkinSerg@users.noreply.github.com>
Co-Authored-By: ZhilkinSerg <ZhilkinSerg@users.noreply.github.com>
data/json/items/ammo/300BLK.json
Outdated
| @@ -1,45 +0,0 @@ | |||
| [ | |||
There was a problem hiding this comment.
Was this file deleted accidentally?
There was a problem hiding this comment.
I spoke to people on the discord about the problem that someone else had modified 300BLK extensively right around same time as I was adding apoc_price to all the ammo jsons. They suggested that since it was my first time contributing that I delete 300BLK from my PR request so my changes don't go conflict with the already mainlined changes and then I can come back and add apoc price specifically to that one file. I'm worried that I made my PR say it should delete 300BLK file entirely from mainstream. Please let me know which one I've done and if I can fix it?
There was a problem hiding this comment.
I see. Yes, I guess there was some kind of miscommunication and by "deleting file X from pr" these people suggested "not doing changes in file X". I will restore the file.
There was a problem hiding this comment.
Just check whether prices are okay in this file now and we are good to go.
There was a problem hiding this comment.
Ok I resolved the multiple price issue. Thank you!
* ApocPrice added Adds "price_postapoc" to all ammo types, used existing price as price_postapoc" guesstimated pre cataclysm price with current prices and inflation and sensibility. Example rounded 9mm to $1 rather than put in 18 cents. If someone wants to make use of these feel free to edit prices. This was more about building infrastructure.
Adds "price_postapoc" to all ammo types, used existing price as price_postapoc" guesstimated pre cataclysm price with current prices and inflation and sensibility. Example rounded 9mm to $1 rather than put in 18 cents. If someone wants to make use of these feel free to edit prices. This was more about building infrastructure.
Summary :
Summary: Infrastructure "Added post-apocalyptic prices to all ammo types."
Purpose of change
This was on the list of first time contributors to help with.
Describe the solution
I added price_postapoc to all ammo items with an extant price.
Describe alternatives you've considered
Not helping.