QOL improvement: "Don't prompt for a direction for an action if there is only one direction possible" #33431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e direction possible CleverRaven#33402" - for lockpicking
ZhilkinSerg
added
[C++]
|
Doesn't fix #33402 – make sure to change the description so it won't automatically close it :) I'll move that issue to a series of checkboxes so we can see progress on this |
ipcyborg
changed the title
misterprimus
pushed a commit
to misterprimus/Cataclysm-DDA
that referenced
this pull request
Sep 21, 2019
… is only one direction possible" (CleverRaven#33431) * Fixed "Don't prompt for a direction for an action if there is only one direction possible CleverRaven#33402" - for lockpicking * Added message and cancel action if there is no lock to pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Features "Quality of Life improvement: don't prompt for a direction for an action if there is only one direction possible"Purpose of change
To simplify the usage of lockpicks on doors.
Describe the solution
Related to #33402.
Added a set of proper lockpicking targets.
Check if there is only one of them is adjacent to player.
If yes, than just lock pick it. If no, then prompt for direction.
If there is nothing to lockpick, then cancel action with a message (don't prompt for direction).
Describe alternatives you've considered
Do the same for other actions?
I see that some of them, like
ACTION_BUTCHER, usecan_interact_atto filter tiles available for this specific action. It also provides visual information if used inexamineaction.But I think that lock picking should be turned into proper action then, right?
Additional context
None