Enable readability-inconsistent-declaration-parameter-name #33425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
[C++]
This check enforces that parameter names in declarations should match those in definitions.
jbytheway
force-pushed
the
clang_tidy_readability_inconsistent_declaration_parameter_name
branch
from
c7fa7db to
da53b5c
Compare
jbytheway
deleted the
clang_tidy_readability_inconsistent_declaration_parameter_name
branch
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
More static analysis.
This check enforces that parameter names in declarations should match those in definitions. This helps ensure that names are updated when their semantics change.
Describe the solution
Enable the
clang-tidycheckreadability-inconsistent-declaration-parameter-name.Fix the cases it complains about.
Some other name changes that I felt were necessary as I was looking at surrounding code.
Describe alternatives you've considered
clang-tidyalways keeps the definition name the same and updates declaration names. In some cases I manually switched the name the other way.There might be other cases where it would have been good to do so. Naming is hard.
Additional context
Random fact: I think this is the longest check name so far (not counting the static analysis checks).