Fix monsters spawn not giving precedence to designated location #33421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralreegorganon
added
Map / Mapgen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix monsters spawn not giving precedence to designated location"
Purpose of change
Fixes the issue where monsters were not being placed in their designated locations, but rather a random location within range. Caused by the refactoring in #33244 which unintentionally changed the behavior--previously the game would first attempt to spawn the monster at the requested location, and then fall back to a random location. After the update, it would just pick a random location immediately.
Describe the solution
Reintroduced the logic of first attempting placement in the designated location, and then falling back to a random point, while retaining the improvement in random point selection.
Additional context
Most noticeable with turret spawning in lab surface entry location, which always had their turrets placed at a specific location, but after #33244 were placing them in random locations.