Reset item pointer after wielding item currently being invoked. #33405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the item has been wielded, the pointer `ìt` (the item previously, e.g. in the inventory or on the ground) is now invalid.
The check at the top of the function makes sure `it` is actually a pointer to the wielded weapon, so using either is the same. This change just makes the code more consistent: it uses `it` like in all the other iuse functions. And `it` is already used at one place to get the recipe anyway.
At least one iuse function (`iuse::craft` when the item was not wielded) removes the item. Accessing it afterwards is UB. (Search for `p->i_rem( it )` in "iuse.cpp" to find those places.)
ZhilkinSerg
added
[C++]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY: NoneSee commit messages. In short the
iusefunction did wield the item, but that invalidates theitpointer (which may be an item in the main inventory, which is not there anymore after wielded it).Fixes #32009 and fixes #33398.