Fixes dealing-attack judgment when riding on monsters #33388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
<Bugfix>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fixes dealing-attack judgment when riding on monsters"
Purpose of change
Fixes #33361-Mountable creatures fail to block attacks for the riders
Now big mounts or mounts with MECH_DEFENSIVE flag can protect their riders,
Describe the solution
Rewrites Creature::deal_melee_attack() & deal_projectile_attack(), changes the subject from the ridden monster to the rider.
Describe alternatives you've considered
Add a "rider" attribute to the Creature class and merge all the being-attacked judgment of the rider into the ridden monster's judgment.
Additional context
(Compiled & tested successfully on Mac)