Track kills through event bus #33369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbytheway
force-pushed
the
kills_through_event_bus
branch
from
4da8d99 to
c9dc410
Compare
ZhilkinSerg
added
[C++]
|
I think you're on track to finally be the one to claim the $110 bounty on #4173 |
Yes, that is indeed my end goal. |
This is intended as the first application of the event_bus. Create a new class kill_tracker which counts the player's kills. This functionality used to be directly in game. Move all the relevant functions from game to kill_tracker to work with that data. Also, add an event_bus to game, and make the kill_tracker a subscriber to it. Communicate information about kills via the event_bus, rather than having dedicated member functions of game for that purpose. Add suitable (de)serialization code to save this data and migrate the old format.
jbytheway
force-pushed
the
kills_through_event_bus
branch
from
c9dc410 to
c67a08b
Compare
|
Now rebased and tests green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Track kills through event_bus in new dedicated kill_tracker class"
Purpose of change
To reduce the code bloat in
game, to decrease coupling, and to demonstrate the utility of the newevent_busclass.Describe the solution
Note that this change builds on top of #33344 and #32891; a lot of the changes you see here are part of those PRs.Now those are merged, rebased on master.Create a new class
kill_trackerwhich counts the player's kills. This functionality used to be directly ingame. Move all the relevant functions fromgametokill_trackerto work with that data.Also, add an
event_bustogame, and make thekill_trackera subscriber of it.Communicate information about kills via the
event_bus, rather than having dedicated member functions ofgamefor that purpose.Add suitable (de)serialization code to save this data and migrate the old format.
Describe alternatives you've considered
When a
Characteris killed, I chose to put the name directly in theevent. I could have only provided thecharacter_id, and had thekill_trackerfetch the name itself, but I thought I would mimic the previous interface for now. I was also slightly concerned that theCharactermight not be loadable any more if they are dead; didn't look into that.Additional context
This seemed like the simplest functionality that made sense to be built on top of the
event_busto provide a real-world test of its functionality before moving on to more ambitious projects.Next I would like to make a subscriber that performs all the memorial logging, rather than having that logging code scattered around the codebase.