Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use point in game, line, map APIs #33351

Merged
merged 7 commits into from
Aug 19, 2019

Conversation

jbytheway
Copy link
Contributor

Summary

SUMMARY: Infrastructure "Convert some game, line, and map APIs to use points"

Purpose of change

My ongoing campaign to increase use of point for better type safety and code clarity.

Describe the solution

This time I've done:

  • The remaining functions in map.h
  • Functions in game.h
  • Functions in line.h

I made some enhancements to my tool for finding these APIs (not yet published) which discovered the map.h functions I missed last time around.

Also, added a tripoint overload for abs (I already added a point overload in a prior PR).

Additional context

In support of #32017.

@ZhilkinSerg ZhilkinSerg added [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style labels Aug 19, 2019
@ZhilkinSerg ZhilkinSerg merged commit c9e4519 into CleverRaven:master Aug 19, 2019
@jbytheway jbytheway deleted the point_in_game_line_map branch August 19, 2019 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants