Fixed "Memory leak and crash when falling asleep with a radio on #32968"

[ipcyborg]

Summary

SUMMARY: Bugfixes "Memory leak and crash when falling asleep with a radio on #32968"

Purpose of change

Fixes #32968

Describe the solution

Fixed by checking if the radio channel (number 21) is already playing something.
Assumed that a single channel should not be spammed with more sound.
UPDATE: found Channel assignments in sfx::do_ambient.

Describe alternatives you've considered

Check other usage of this channel.
Check other channels too.
Check sdlsound.cpp: if the memory allocated for a sound is always released?

Additional context

UPDATE:
Allocating memory in do_pitch_shift, using in:
play_variant_sound
play_variant_sound_pitch
play_ambient_variant_sound

Should be freed after the channel is finished.

play_ambient_variant_sound is relatively safe, since it has a channel parameter. So this channel could be checked before playing the sound.
The other two functions has angle, but not channel. So the sound will be played on first available channel.

Suggestion:

1. Add channel to two other functions.
2. Check every channel before playing a sound inside of these functions. Avoid sound spamming.

[ZhilkinSerg]

Maybe we should make channel enum to get rid of all these magic numbers?

[ipcyborg]

UPDATE:

Added enums for channels & groups of sound effects.
Moved outdoor_blizzard closer to other outdoor sounds.
Added missing check for "Outdoor blizzard" in sfx::do_ambient.
Added check "is channel playing" inside of play_ambient_variant_sound. May not be necessary, leads to double checks. Just to be sure?
Fixed playing radio/chatter as play_ambient_variant_sound.
Added separate channel for radio (instead of using player activity channel).
Reordered danger channels.
Fixed init_sound groups assignment.
Avoid pitching a sound when it is not required: like when only angle is set, but no pitch.
Changed default pitch to -1.0 (as not pitched). Probably make steps for pitch and cache pitched sound effects for optimization?.
Added error handling in play sound functions.
Added loops parameter to play_ambient_variant_sound function.
Added stop_sound_effect_timed to stop sound effect after a given time.
Altered active radio "choose what to play" algorithm. Some chance to play static or chatter, but only once (should not be annoying).

[ipcyborg]

Found an issue with "@" soundpack on my system:

"type": "sound_effect",
"id" : "environment",
"variant" : "daytime",
"volume" : 85,
"files" : [
        "env/ambience_and_weather/daytime_1.ogg",
        "env/ambience_and_weather/daytime_2.ogg",
        "env/ambience_and_weather/daytime_2.mp3"
]

The last file daytime_2.mp3 now gives the following error when played:
sdlsound.cpp:543: Failed to play sound effect: Tried to play a chunk with a bad frame
This file is missing in the soundpack.
But also looks like this format (mp3) could not be payed using SDL. Ogg files are ok.
The error just goes into log.
Should I remove the error logging from play_ambient_variant_sound and other functions?

• OS: Linux
  • OS Version: Distributor ID: Ubuntu; Description: Ubuntu 16.04.6 LTS; Release: 16.04; Codename: xenial;
• Game Version: 0.D-6617-gf7415e1 [64-bit]
• Graphics Version: Tiles
• Mods loaded: [
  Dark Days Ahead [dda],
  Disable NPC Needs [no_npc_food]
  ]

Probably related:
https://sites.google.com/site/sdlgamer/beginner/lesson-12
Some specific lib is required: smpeg.dll 192k (For mp3 format music file).
Or just SDL2.