Point in mapgen #32844
Merged
Point in mapgen #32844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also prevent some variable shadowing. There's a lot of 'offset' values here which can be rather confusing. Hopefully it's all refactored correctly. No semantic change intended.
ZhilkinSerg
added
[C++]
misterprimus
pushed a commit
to misterprimus/Cataclysm-DDA
that referenced
this pull request
Sep 21, 2019
* point overloads for map set functions * Port a bunch of mapgen code to use points Also prevent some variable shadowing. There's a lot of 'offset' values here which can be rather confusing. Hopefully it's all refactored correctly. No semantic change intended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
My ongoing campaign to increase use of
pointandtripointfor type safety and code clarity.Describe the solution
Refactor some mapgen code to use
pointmore.Add some
pointoverloads tomapmember functions for this mapgen code to call.Describe alternatives you've considered
I wondered whether the mapgen should really be calling the
tripointoverloads ofmap::set, etc. But I didn't want to think about it too hard.Additional context
Working towards #32017.