Use point more in graphics code #32732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace three ints with a tripoint.
BevapDin
reviewed
Jul 29, 2019
BevapDin
reviewed
Jul 29, 2019
BevapDin
reviewed
Jul 29, 2019
BevapDin
reviewed
Jul 29, 2019
This was referenced Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
My ongoing effort to make more use of
pointand related classes to improve type safety and code clarity.Describe the solution
Rewrite a bunch of GUI code to make more use of
point.Removed
cata_tiles::last_pos_x,yentirely because they were unused.No change to behaviour intended.
Additional context
More similar PRs are incoming. This was inspired by #32017 but this PR is not specifically in support of it.