Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CR] Updates martialarts_json.md doc #30706

Merged
merged 3 commits into from
May 21, 2019

Conversation

Mooses2k
Copy link
Contributor

Summary

SUMMARY: Infrastructure "Updates martialarts_json.md doc"

Purpose of change

It was out of date and I just worked on some martial arts code, so I thought I'd improve it.

Describe the solution

Went through techniques.json and martialarts.json, put in everything I could think of that might help.

BE AWARE, knockback_follow references #30668 which is not yet merged.

Describe alternatives you've considered

Doing nothing, but that's not very helpful.

Additional context

"Weighting" and "Defensive" - somebody chime in on these, please

@ifreund ifreund added <Documentation> Design documents, internal info, guides and help. [Markdown] Markdown issues and PRs Melee Melee weapons, tactics, techniques, reach attack labels May 21, 2019
@Hymore246
Copy link
Contributor

Defensive - Used by the game to automatically exclude a technique from being randomly selected to use when attacking.

Weighting - Effects how likely the technique will be randomly selected when attacking. The number indicates how many extra "copies" are added to the technique pool when doing a random pick. This can be negative value which will reduce the chance of of the tech triggering.

AoE - Both Wide and Spin have extra checks in the code before they can be picked and used. Spin requires at least 2 hostile creatures to be adjacent to the player in order to be a valid pick. Wide requires at least 2 hostile creatures to be adjacent to the player and the attacked target must have another creature adjacent to it. In other words, AoE techs CANNOT trigger against solo targets.

@Mooses2k
Copy link
Contributor Author

Thanks. Changes made. It's all ready, in my eyes.

@kevingranade kevingranade merged commit 8ba87dd into CleverRaven:master May 21, 2019
@Mooses2k Mooses2k deleted the martialarts_json.md-update branch May 21, 2019 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Documentation> Design documents, internal info, guides and help. [Markdown] Markdown issues and PRs Melee Melee weapons, tactics, techniques, reach attack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants