Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parking garage #30556

Merged
merged 7 commits into from
May 17, 2019
Merged

Parking garage #30556

merged 7 commits into from
May 17, 2019

Conversation

LovamKicsiGazsii
Copy link
Contributor

Summary

SUMMARY: Content "Adds parking garages"

Purpose of change

Adds more parking spaces and some more terrain.
Also, variety.

Describe the solution

Added 2x1x4 parking garage including an underground and a rooftop parking space. It has a space for 49 cars.

Additional context

Pony wall is concrete railing and the yellow wall is the yellow concrete floor.
parking_garage_1
parking_garage_0
(2x)
parking_garage_3
parking_garage_2

@dom4op
Copy link

dom4op commented May 16, 2019

Umm, it doesn't look like an SUV would fit in one of those elevators. And yet we see it on the upper level

@LovamKicsiGazsii
Copy link
Contributor Author

Fixed it.
fix
Now the SUV fits in the elevator. This wasn't really important, because you still can't bring the car down.

@ifreund ifreund added <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display labels May 16, 2019
@JeanLucVanDamme
Copy link

I like this addition no matter what.

But it does remove some of the fun / emergent-gameplay-ness that you can't take the car down. Is that a choice, or is that kind of behavior (e.g., changing z-levels while/with a vehicle) not possible yet?

But hey, if working car-elevators are impossible, you still have two options. One, drive a car off the 2nd floor edge, hope you survive. Two, elevated parking garage base, with the greatest barricades of all (leave cars in front of the stairs to block incoming zeds).

@anothersimulacrum
Copy link
Member

One, drive a car off the 2nd floor edge, hope you survive.

Right now, this will just lead to you driving a car through the open air.
Perhaps cars spawning on the upper levels should be removed for now and revisited once vehicles properly transition z-levels?

@kevingranade
Copy link
Member

It's currently not possible to drive a car down a ramp, and it's not possible to use the elevator since they would have no power.

It's inconsistent either way. Either you have no cars on top of parking garage where you would expect them to be, or you have cars on top of parking garages and can't get them down. I would prefer to have the cars there than not.

@Rail-Runner
Copy link
Contributor

Rail-Runner commented May 17, 2019

Perhaps cars spawning on the upper levels should be removed for now and revisited once vehicles properly transition z-levels?

Well, I think it has to be solved somehow either way. If it's true and vehicles don't spawn on other Z-levels, then even as it currently is, player can build a foldable vehicle, fold it, bring it upstairs, unfold and drive it thorough the air.

@kevingranade kevingranade merged commit cf27cfe into CleverRaven:master May 17, 2019
@JeanLucVanDamme
Copy link

Here's another vote for keeping the cars on the 2nd level, even if you can't get them down yet.

@LovamKicsiGazsii LovamKicsiGazsii deleted the patch-31 branch December 30, 2021 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants