Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small rotting fixes #30125

Merged
merged 7 commits into from
May 1, 2019
Merged

Conversation

Hirmuolio
Copy link
Contributor

@Hirmuolio Hirmuolio commented Apr 30, 2019

Summary

SUMMARY: Bugfixes "fix out of reality rotting and other small things"

Purpose of change

  • Show rot info on foods that are in containers
  • Fix foods not rotting right when they are outside reality bubble in many situations

The most noticeable broken thing is that when you arrive to a new house long time after start the food isn't rotten as it is supposed to be. This fixes that.

Describe the solution

  • Handle it better when temperature and rot calculations are out of sync by iterating from earlier of the two.
  • Set last_rot_check to the processed time instead of current time.
  • One missing last_rot_check.
  • Don't use bday for rot calculation. last_rot_check is set with last_temp_check.

Describe alternatives you've considered

Additional context

@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Mechanics: Temperature Freezing, cooling, thawing, heating, etc. mechanics labels Apr 30, 2019
@kevingranade kevingranade merged commit 53a14e1 into CleverRaven:master May 1, 2019
@Hirmuolio Hirmuolio deleted the Hirmuolio-temp-fixes branch May 1, 2019 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Mechanics: Temperature Freezing, cooling, thawing, heating, etc. mechanics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants