Correct the display of skinned human corpses. #30116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlangsdorf
added
<Bugfix>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Correct the display of skinned human corpses."
Purpose of change
Skinned human corpses were being passed to
string_formatwith an incomplete argument list, resulting in text errors. This impacted any UI element where the corpse item name would be displayed.Describe the solution
Pass the expected arguments to
string_formatDescribe alternatives you've considered
The whole block of code for selecting the strings for how to display corpses (skinned or otherwise) is pretty clunky, so it could probably be refactored, but being honest I wanted out of that thoughtspace as quickly as I could escape.
Additional context
Erroneous text:
Corrected text:
