-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sandbags/earthbags, earthbag walls, adjust sandbag walls WIP #29855
Conversation
"PERMEABLE" | ||
], | ||
"examine_action": "chainfence", | ||
"deconstruct": { "items": [ { "item": "sandbag", "count": 16 } ] }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deconstruct and bash results for this one (and earthbag wall) still mention sand and sandbags. Likely unintended.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, that's an editing oversight.
"skill_used": "fabrication", | ||
"time": 2000, | ||
"autolearn": true, | ||
"qualities": [ { "id": "DIG", "level": 3 } ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why digging 3 would be needed, really you can fill sandbags with your hands if you want. Digging 1 would probably be plenty.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see an argument to be made about what is and is not needed, but digging 1
is basically "a sharp stick" rather than anything that can actually be used to effectively move sand or soil
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that the soil or sand used here is already dug up, and probably in a loose pile. Since you have to get the material somehow tool quality is still a factor, but when filling the bag it should not matter that much. Alternative would to make duplicate recipies for different speeds and shovel qualities, but that seems bloated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been pushing for the ability to make a second quality field that allows certain qualities to speed up the recipe, but not be required to make it. that would be appropriate here. Really I don't think any tool quality at all is needed to fill a sandbag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A trowel also have digging 1 quality.
At least decrease this to digging level 2, otherwise one wouldn't be able to use makeshift shovels for filling a bag.
Is this PR ready to merge? I can review if that's the only hold up |
I think so, I've been passing over it because of the WIP label. |
I pretty much realized I didn't really want to be thinking about the balance stuff. If it's acceptable as-is, go for it. If someone wants to take it to hammer it into better shape, that's cool too. I otherwise wasn't intending to put much more thought into it |
Summary
SUMMARY: Content "Add sandbags/earthbags, earthbag walls, adjust sandbag walls"
Purpose of change
The current sandbag barricades/walls a) take too long for a task that should simply be 'stack sandbags', b) don't actually accept sandbags (due to them not existing)
Further, soil is currently completely unused by the game despite being produced in fairly large quantities if you do any meaningful amount of digging.
Describe the solution
Added sandbag and earthbag items and appropriate recipes.
Adjusted sandbag barricades/walls to use the new items, as well as added earthbag barricades/walls.
Also slightly adjusted density of sand; the current density results in 2000 kg/m3, which according to research should be closer to 1600 kg/m3 for dry sand (which most of what we would be dealing with should be). Taking the in-game weight value from
10
to8
accomplishes this.Some data:
A single Canvas Sack can hold up to 15 liters of material, while being 1 liter itself. I decided to go with 16L for the resultant sandbag/earthbag to account for the 'bulkiness' factor. With the respective densities, a sandbag is 24.4kg, and an earthbag is 19.5kg.
Currently barricades need 16 bags (which is a total volume of 256 L), and upgrading a barricade to a wall needs another further 20 bags (a total volume of 576 L).
Research on ergonomics of shoveling with a given condition of 'continuous shovelling' suggests 22-33kg can be precisely shoveled in about a minute, but I figured without a dedicated rig canvas sacks would be a bit more cumbersome than that, so went with 2 minutes per bag (and the recipe does require a proper shovel of
digging 3
).I went with 16 minutes for making a barricade (effort for stacking/aligning 16 bags), and another 20 minutes for making a wall (another 20 bags of stacking/aligning).
This means it takes 48 minutes labor to make a barricade (assuming you already have the sand and sacks), another 60 minutes of labor to turn it into a full wall.
Describe alternatives you've considered
I would have liked to have just used soil as a possible ingredient to sandbags, but at present constructions don't remember what they were made of, so using sandbags made out of soil would allow trivial transmutation of sand to soil (which is just weird to me), as well as potentially resulting in piles of sand when earthbag barricades/walls are destroyed (which is also weird).
Additional context
I do not properly understand how the destructibility rules work for furniture, but it seems to me that sandbag (and to a lesser extent earthbag) barricades/walls should probably be fairly durable, but I don't know how to represent that with the mechanisms available.
There's also a variety of specialized (if simple to make) rigs to allow quickly filling multiple sandbags in a row. I haven't represented this here, but I'm not opposed to doing so.
Feedback welcome.