Traps disarming gives morale effects #29466
Conversation
ifreund
added
<Enhancement / Feature>
| { | ||
| "id": "morale_accomplishment", | ||
| "type": "morale_type", | ||
| "text": "Accomplishment" |
There was a problem hiding this comment.
This seems like to be a way too generic name. Imagine we add several reasons for this morale bonus to shoot, and the player could see several "Accomplishment"s in his morale display. I believe it needs to be specified to what type of accomplishment caused this morale boost.
There was a problem hiding this comment.
It was intentional. We should use generic morale types and less of them instead of creating more of similar types.
There was a problem hiding this comment.
There used to be a stacking issue, but now it's just a matter of avoiding clutter in the UI, which is still a pretty big deal. The player is notified specifically what the accomplishment was when they perform the action, but minutes or hours later, does it matter what it was, or that they're happy about it?
|
I'm not sure it makes sense. Seems like it makes it possible for player to get morale boost from placing a trap and then disarming it immediately, which is weird. |
|
To me making a successful complex craft or construction (the one that could fail), successfully passing speech check with NPC and successful hacking and bionic installation seems to be more in line with what I feel than trap disarming... Also mini-boss killing, at least for the first time. Of course getting rid of Fungal Tower is give nearly the best morale buff IRL :) |
And you may fail and trigger it. Get a morale debuff and more nasty things. |
|
I would also opt for reducing the bonus according to progression in traps skill by dividing the bonus by the players's skill. A professional trapper would barely notice the effects of success of disarming yet another trap, while disarming a landmine by a novice might be an achievement. |
|
I agree. And what about negative morale effects? Should they increase with skill progression? |
AMurkin
force-pushed
the
morale-boost-trap-disarming
branch
from
eb57706 to
9d7d88e
Compare
|
Rebased to resolve merge conflicts. |
Summary
SUMMARY: Features "Traps disarming gives morale effects"Purpose of change
Add the impact of success or failure of trap disarming.
Introduce generic morale types.
Describe the solution
Added generic morale types Accomplishment and Failure.
Apply
Accomplishmentmorale buff on successful trap disarming.Apply
Failuremorale debuff on failed trap disarming.Additional context
Don't know if morale effects are good inside the
map.cpp.